nick/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2026-02-07 19:32:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix crash after calling EditorUndoRedoManager.clear_history() and then interacting with history dock entries

Browse Source
This commit is contained in:
Robert Yevdokimov
2025-12-30 06:09:29 -05:00
parent 63227bbc8a
commit dc08fd48cb
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
doc/classes/EditorUndoRedoManager.xml
View File

@@ -73,7 +73,7 @@
<param index="0" name="id" type="int" default="-99" />
<param index="1" name="increase_version" type="bool" default="true" />
<description>
Clears the given undo history. You can clear history for a specific scene, global history, or for all scenes at once if [param id] is [constant INVALID_HISTORY].
Clears the given undo history. You can clear history for a specific scene, global history, or for all histories at once (except [constant REMOTE_HISTORY]) if [param id] is [constant INVALID_HISTORY].
If [param increase_version] is [code]true[/code], the undo history version will be increased, marking it as unsaved. Useful for operations that modify the scene, but don't support undo.
[codeblock]
var scene_root = EditorInterface.get_edited_scene_root()

7
editor/editor_undo_redo_manager.cpp
View File

@@ -447,8 +447,13 @@ void EditorUndoRedoManager::clear_history(int p_idx, bool p_increase_version) {
return;
}
for (const KeyValue<int, History> &E : history_map) {
for (KeyValue<int, History> &E : history_map) {
if (E.key == REMOTE_HISTORY) {
continue;
}
E.value.undo_redo->clear_history(p_increase_version);
E.value.undo_stack.clear();
E.value.redo_stack.clear();
set_history_as_saved(E.key);
}
emit_signal(SNAME("history_changed"));